Skip to content

Conversation

@lenemter
Copy link
Member

No description provided.

@lenemter lenemter requested a review from a team October 28, 2025 19:08
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep in line with how we do it in the other classes by passing on construct and then binding without sync create? Of course the rounded corners effect doesn't do that much when setting the scale but in theory we don't know that and should avoid it if we can.

@lenemter
Copy link
Member Author

@leolost2605 Done!

@lenemter lenemter requested a review from leolost2605 October 29, 2025 18:59
@lenemter lenemter mentioned this pull request Oct 29, 2025
7 tasks
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one little comment apart from that looks great!

@lenemter lenemter requested a review from leolost2605 October 30, 2025 13:07
@danirabbit danirabbit enabled auto-merge (squash) October 30, 2025 15:48
@danirabbit danirabbit merged commit 3458e11 into main Oct 30, 2025
6 checks passed
@danirabbit danirabbit deleted the lenemter/scale-tooltip-corner-radius branch October 30, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants